| 1 |
|
|
| 2 |
|
|
| 3 |
|
|
| 4 |
|
|
| 5 |
|
|
| 6 |
|
|
| 7 |
|
|
| 8 |
|
|
| 9 |
|
|
| 10 |
|
|
| 11 |
|
|
| 12 |
|
|
| 13 |
|
|
| 14 |
|
|
| 15 |
|
|
| 16 |
|
|
| 17 |
|
|
| 18 |
|
|
| 19 |
|
package com.puppycrawl.tools.checkstyle.checks.coding; |
| 20 |
|
|
| 21 |
|
import com.puppycrawl.tools.checkstyle.api.Check; |
| 22 |
|
import com.puppycrawl.tools.checkstyle.api.DetailAST; |
| 23 |
|
import com.puppycrawl.tools.checkstyle.api.Scope; |
| 24 |
|
import com.puppycrawl.tools.checkstyle.api.ScopeUtils; |
| 25 |
|
import com.puppycrawl.tools.checkstyle.api.TokenTypes; |
| 26 |
|
import java.util.Stack; |
| 27 |
|
|
| 28 |
|
|
| 29 |
|
|
| 30 |
|
|
| 31 |
|
|
| 32 |
|
|
| 33 |
|
|
| 34 |
|
|
| 35 |
|
|
| 36 |
|
|
| 37 |
|
|
| 38 |
|
|
| 39 |
|
|
| 40 |
|
|
| 41 |
|
|
| 42 |
|
|
| 43 |
|
|
| 44 |
|
|
| 45 |
|
|
| 46 |
|
|
| 47 |
|
|
| 48 |
|
|
| 49 |
|
|
| 50 |
|
|
| 51 |
|
|
| 52 |
|
|
| 53 |
|
|
| 54 |
|
|
| 55 |
|
@author |
| 56 |
|
|
|
|
|
| 88.6% |
Uncovered Elements: 8 (70) |
Complexity: 19 |
Complexity Density: 0.4 |
|
| 57 |
|
public class DeclarationOrderCheck extends Check |
| 58 |
|
{ |
| 59 |
|
|
| 60 |
|
private static final int STATE_STATIC_VARIABLE_DEF = 1; |
| 61 |
|
|
| 62 |
|
|
| 63 |
|
private static final int STATE_INSTANCE_VARIABLE_DEF = 2; |
| 64 |
|
|
| 65 |
|
|
| 66 |
|
private static final int STATE_CTOR_DEF = 3; |
| 67 |
|
|
| 68 |
|
|
| 69 |
|
private static final int STATE_METHOD_DEF = 4; |
| 70 |
|
|
| 71 |
|
|
| 72 |
|
|
| 73 |
|
|
| 74 |
|
|
| 75 |
|
private final Stack mScopeStates = new Stack(); |
| 76 |
|
|
| 77 |
|
|
| 78 |
|
|
| 79 |
|
|
|
|
|
| - |
Uncovered Elements: 0 (0) |
Complexity: 0 |
Complexity Density: - |
|
| 80 |
|
private class ScopeState |
| 81 |
|
{ |
| 82 |
|
|
| 83 |
|
private int mScopeState = STATE_STATIC_VARIABLE_DEF; |
| 84 |
|
|
| 85 |
|
|
| 86 |
|
private Scope mDeclarationAccess = Scope.PUBLIC; |
| 87 |
|
} |
| 88 |
|
|
| 89 |
|
@inheritDoc |
|
|
|
| 100% |
Uncovered Elements: 0 (1) |
Complexity: 1 |
Complexity Density: 1 |
|
| 90 |
1
|
public int[] getDefaultTokens()... |
| 91 |
|
{ |
| 92 |
1
|
return new int[] { |
| 93 |
|
TokenTypes.CTOR_DEF, |
| 94 |
|
TokenTypes.METHOD_DEF, |
| 95 |
|
TokenTypes.MODIFIERS, |
| 96 |
|
TokenTypes.OBJBLOCK, |
| 97 |
|
}; |
| 98 |
|
} |
| 99 |
|
|
| 100 |
|
@inheritDoc |
|
|
|
| 86.9% |
Uncovered Elements: 8 (61) |
Complexity: 16 |
Complexity Density: 0.39 |
|
| 101 |
70
|
public void visitToken(DetailAST aAST)... |
| 102 |
|
{ |
| 103 |
70
|
final int parentType = aAST.getParent().getType(); |
| 104 |
70
|
ScopeState state; |
| 105 |
|
|
| 106 |
70
|
switch(aAST.getType()) { |
| 107 |
5
|
case TokenTypes.OBJBLOCK: |
| 108 |
5
|
mScopeStates.push(new ScopeState()); |
| 109 |
5
|
break; |
| 110 |
|
|
| 111 |
4
|
case TokenTypes.CTOR_DEF: |
| 112 |
4
|
if (parentType != TokenTypes.OBJBLOCK) { |
| 113 |
0
|
return; |
| 114 |
|
} |
| 115 |
|
|
| 116 |
4
|
state = (ScopeState) mScopeStates.peek(); |
| 117 |
4
|
if (state.mScopeState > STATE_CTOR_DEF) { |
| 118 |
2
|
log(aAST, "declaration.order.constructor"); |
| 119 |
|
} |
| 120 |
|
else { |
| 121 |
2
|
state.mScopeState = STATE_CTOR_DEF; |
| 122 |
|
} |
| 123 |
4
|
break; |
| 124 |
|
|
| 125 |
9
|
case TokenTypes.METHOD_DEF: |
| 126 |
9
|
state = (ScopeState) mScopeStates.peek(); |
| 127 |
9
|
if (parentType != TokenTypes.OBJBLOCK) { |
| 128 |
0
|
return; |
| 129 |
|
} |
| 130 |
|
|
| 131 |
9
|
if (state.mScopeState > STATE_METHOD_DEF) { |
| 132 |
0
|
log(aAST, "declaration.order.method"); |
| 133 |
|
} |
| 134 |
|
else { |
| 135 |
9
|
state.mScopeState = STATE_METHOD_DEF; |
| 136 |
|
} |
| 137 |
9
|
break; |
| 138 |
|
|
| 139 |
52
|
case TokenTypes.MODIFIERS: |
| 140 |
52
|
if ((parentType != TokenTypes.VARIABLE_DEF) |
| 141 |
|
|| (aAST.getParent().getParent().getType() |
| 142 |
|
!= TokenTypes.OBJBLOCK)) |
| 143 |
|
{ |
| 144 |
23
|
return; |
| 145 |
|
} |
| 146 |
|
|
| 147 |
29
|
state = (ScopeState) mScopeStates.peek(); |
| 148 |
29
|
if (aAST.findFirstToken(TokenTypes.LITERAL_STATIC) != null) { |
| 149 |
25
|
if (state.mScopeState > STATE_STATIC_VARIABLE_DEF) { |
| 150 |
5
|
log(aAST, "declaration.order.static"); |
| 151 |
|
} |
| 152 |
|
else { |
| 153 |
20
|
state.mScopeState = STATE_STATIC_VARIABLE_DEF; |
| 154 |
|
} |
| 155 |
|
} |
| 156 |
|
else { |
| 157 |
4
|
if (state.mScopeState > STATE_INSTANCE_VARIABLE_DEF) { |
| 158 |
2
|
log(aAST, "declaration.order.instance"); |
| 159 |
|
} |
| 160 |
2
|
else if (state.mScopeState == STATE_STATIC_VARIABLE_DEF) { |
| 161 |
2
|
state.mDeclarationAccess = Scope.PUBLIC; |
| 162 |
2
|
state.mScopeState = STATE_INSTANCE_VARIABLE_DEF; |
| 163 |
|
} |
| 164 |
|
} |
| 165 |
|
|
| 166 |
29
|
final Scope access = ScopeUtils.getScopeFromMods(aAST); |
| 167 |
29
|
if (state.mDeclarationAccess.compareTo(access) > 0) { |
| 168 |
16
|
log(aAST, "declaration.order.access"); |
| 169 |
|
} |
| 170 |
|
else { |
| 171 |
13
|
state.mDeclarationAccess = access; |
| 172 |
|
} |
| 173 |
29
|
break; |
| 174 |
|
|
| 175 |
0
|
default: |
| 176 |
|
} |
| 177 |
|
} |
| 178 |
|
|
| 179 |
|
@inheritDoc |
|
|
|
| 100% |
Uncovered Elements: 0 (5) |
Complexity: 2 |
Complexity Density: 0.4 |
|
| 180 |
70
|
public void leaveToken(DetailAST aAST)... |
| 181 |
|
{ |
| 182 |
70
|
switch(aAST.getType()) { |
| 183 |
5
|
case TokenTypes.OBJBLOCK: |
| 184 |
5
|
mScopeStates.pop(); |
| 185 |
5
|
break; |
| 186 |
|
|
| 187 |
65
|
default: |
| 188 |
|
} |
| 189 |
|
} |
| 190 |
|
} |